Wen Gong <quic_wgong@xxxxxxxxxxx> writes: > On 3/23/2022 4:47 PM, Kalle Valo wrote: >> Wen Gong <quic_wgong@xxxxxxxxxxx> writes: >> >>> This is to read variant from SMBIOS such as read from DT, the variant >>> string will be used to one part of string which used to search board >>> data from board-2.bin. >>> >>> Tested-on: WCN6855 hw2.0 PCI WLAN.HSP.1.1-03125-QCAHSPSWPL_V1_V2_SILICONZ_LITE-3 >>> >>> Signed-off-by: Wen Gong <quic_wgong@xxxxxxxxxxx> >> [...] >> >>> +struct ath11k_smbios_bdf { >>> + struct dmi_header hdr; >>> + u32 padding; >>> + u8 bdf_enabled; >>> + u8 bdf_ext[1]; >>> +}; >> I was about to commit this but noticed bdf_ext[1], is there a reason for >> that? Use of [1] in arrays is deprecated nowadays: > > Kalle, > > no reason for it, please change bdf_ext[1] to bdf_ext[0] or bdf_ext[]. > It will also work well. [0] is deprecated as well so I changed it to []. -- https://patchwork.kernel.org/project/linux-wireless/list/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches