On Mon, Mar 21, 2022 at 8:51 AM Toke Høiland-Jørgensen <toke@xxxxxxx> wrote:
>
> Wenli Looi <wlooi@xxxxxxxxxxx> writes:
>
> > The current implementation is reading the wrong eeprom type.
> >
> > Fixes: d8ec2e ("ath9k: Add an eeprom_ops callback for retrieving the eepmisc value")
> > Signed-off-by: Wenli Looi <wlooi@xxxxxxxxxxx>
> > ---
> > drivers/net/wireless/ath/ath9k/ar9003_eeprom.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/net/wireless/ath/ath9k/ar9003_eeprom.c b/drivers/net/wireless/ath/ath9k/ar9003_eeprom.c
> > index 669b49b56..a109a44a1 100644
> > --- a/drivers/net/wireless/ath/ath9k/ar9003_eeprom.c
> > +++ b/drivers/net/wireless/ath/ath9k/ar9003_eeprom.c
> > @@ -5615,7 +5615,7 @@ unsigned int ar9003_get_paprd_scale_factor(struct ath_hw *ah,
> >
> > static u8 ar9003_get_eepmisc(struct ath_hw *ah)
> > {
> > - return ah->eeprom.map4k.baseEepHeader.eepMisc;
> > + return ah->eeprom.ar9300_eep.baseEepHeader.opCapFlags.eepMisc;
> > }
>
> Looks like this is only ever used to check for the
> AR5416_EEPMISC_BIG_ENDIAN flag - so is that never used by AR9300, or how
> was this ever working given that it's a completely different offset?
>
> -Toke
I think it's never used by AR9300, because get_eepmisc is only used in
ath9k_hw_nvram_swap_data, which is only used in the eeprom types other
than AR9300.
