On Wed, 2022-03-16 at 18:55 +0000, Grumbach, Emmanuel wrote: > > > > From: Arnd Bergmann <arnd@xxxxxxxx> > > > > Building iwlmei without CONFIG_CFG80211 causes a link-time warning: > > > > ld.lld: error: undefined symbol: ieee80211_hdrlen > > > > > referenced by net.c > > > > > > > > > > net/wireless/intel/iwlwifi/mei/net.o:(iwl_mei_tx_copy_to_csme > > > > > ) in > > > > > archive drivers/built-in.a > > > > Add an explicit dependency to avoid this. In theory it should not > > be needed > > here, but it also seems pointless to allow IWLMEI for > > configurations without > > CFG80211. > > > > Signed-off-by: Arnd Bergmann <arnd@xxxxxxxx> > > --- > > drivers/net/wireless/intel/iwlwifi/Kconfig | 1 + > > 1 file changed, 1 insertion(+) > > > > I see this warning on 5.17-rc8, but did not test it on linux-next, > > which may > > already have a fix. > > > > diff --git a/drivers/net/wireless/intel/iwlwifi/Kconfig > > b/drivers/net/wireless/intel/iwlwifi/Kconfig > > index 85e704283755..a647a406b87b 100644 > > --- a/drivers/net/wireless/intel/iwlwifi/Kconfig > > +++ b/drivers/net/wireless/intel/iwlwifi/Kconfig > > @@ -139,6 +139,7 @@ config IWLMEI > > tristate "Intel Management Engine communication over WLAN" > > depends on INTEL_MEI > > depends on PM > > + depends on CFG80211 > > help > > Enables the iwlmei kernel module. > > > > FWIW: Luca just merged the exact same patch internally. So > Acked-by: Emmanuel Grumbach <Emmanuel.grumbach@xxxxxxxxx> Yeah, please take this. Acked-by: Luca Coelho <luciano.coelho@xxxxxxxxx> -- Cheers, Luca.
