On 3/10/2022 4:00 PM, Kalle Valo wrote:
Wen Gong <quic_wgong@xxxxxxxxxxx> writes:
...
@@ -722,7 +734,7 @@ static int ath11k_core_fetch_board_data_api_n(struct ath11k_base *ab,
out:
if (!bd->data || !bd->len) {
- ath11k_err(ab,
+ ath11k_dbg(ab, ATH11K_DBG_BOOT,
"failed to fetch board data for %s from %s\n",
boardname, filepath);
ret = -ENODATA;
This error message was useful as it made easy to find out what board
data file we are missing. An example:
https://bugzilla.kernel.org/show_bug.cgi?id=215586#c0
So I'm worried it will become more difficult if the message is changed
to a debug message. But I don't know what's a good solution either, we
shouldn't print an error message while we are searching for the board
file and print it only after we could not find any. One idea I have was
to print every boardname we tried to find or just print the first
boardname, but don't know really what's the best.
But to summarise, we need to think carefully how to handle the missing
board file case. It's very common for users that a board file is missing
in board-2.bin so the error message should be informative enough.
Yes,
I think we can change to print the error message after we could not find
any, I will change it in next version patch.
