Hi Lorenzo, I love your patch! Yet something to improve: [auto build test ERROR on wireless-next/main] [also build test ERROR on next-20220310] [cannot apply to wireless/main v5.17-rc7] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch] url: https://github.com/0day-ci/linux/commits/Lorenzo-Bianconi/introduce-mt7921u-driver/20220313-205210 base: https://git.kernel.org/pub/scm/linux/kernel/git/wireless/wireless-next.git main config: i386-allyesconfig (https://download.01.org/0day-ci/archive/20220313/202203132225.CbMappWu-lkp@xxxxxxxxx/config) compiler: gcc-9 (Ubuntu 9.4.0-1ubuntu1~20.04) 9.4.0 reproduce (this is a W=1 build): # https://github.com/0day-ci/linux/commit/63a67380659a7ab972a09206bc2b581fdb6766b6 git remote add linux-review https://github.com/0day-ci/linux git fetch --no-tags linux-review Lorenzo-Bianconi/introduce-mt7921u-driver/20220313-205210 git checkout 63a67380659a7ab972a09206bc2b581fdb6766b6 # save the config file to linux build tree mkdir build_dir make W=1 O=build_dir ARCH=i386 SHELL=/bin/bash If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot <lkp@xxxxxxxxx> All errors (new ones prefixed by >>): drivers/net/wireless/mediatek/mt76/mt7921/usb_mac.c: In function 'mt7921u_mac_reset': >> drivers/net/wireless/mediatek/mt76/mt7921/usb_mac.c:224:8: error: too many arguments to function 'mt7921u_dma_init' 224 | err = mt7921u_dma_init(dev, false); | ^~~~~~~~~~~~~~~~ drivers/net/wireless/mediatek/mt76/mt7921/usb_mac.c:124:5: note: declared here 124 | int mt7921u_dma_init(struct mt7921_dev *dev) | ^~~~~~~~~~~~~~~~ vim +/mt7921u_dma_init +224 drivers/net/wireless/mediatek/mt76/mt7921/usb_mac.c 196 197 int mt7921u_mac_reset(struct mt7921_dev *dev) 198 { 199 int err; 200 201 mt76_txq_schedule_all(&dev->mphy); 202 mt76_worker_disable(&dev->mt76.tx_worker); 203 204 set_bit(MT76_RESET, &dev->mphy.state); 205 set_bit(MT76_MCU_RESET, &dev->mphy.state); 206 207 wake_up(&dev->mt76.mcu.wait); 208 mt7921_mcu_exit(dev); 209 210 mt76u_stop_rx(&dev->mt76); 211 mt76u_stop_tx(&dev->mt76); 212 213 mt7921u_wfsys_reset(dev); 214 215 clear_bit(MT76_MCU_RESET, &dev->mphy.state); 216 err = mt76u_resume_rx(&dev->mt76); 217 if (err) 218 goto out; 219 220 err = mt7921u_mcu_power_on(dev); 221 if (err) 222 goto out; 223 > 224 err = mt7921u_dma_init(dev, false); --- 0-DAY CI Kernel Test Service https://lists.01.org/hyperkitty/list/kbuild-all@xxxxxxxxxxxx
