Re: [PATCH] brcmfmac: check the return value of devm_kzalloc() in brcmf_of_probe()

[Jia-Ju Bai <baijiaju1990@xxxxxxxxx>]

On 2022/3/11 0:09, Kalle Valo wrote:
> Jia-Ju Bai <baijiaju1990@xxxxxxxxx> wrote:
>
> > The function devm_kzalloc() in brcmf_of_probe() can fail, so its return
> > value should be checked.
> >
> > Fixes: 29e354ebeeec ("brcmfmac: Transform compatible string for FW loading")
> > Reported-by: TOTE Robot <oslab@xxxxxxxxxxxxxxx>
> > Signed-off-by: Jia-Ju Bai <baijiaju1990@xxxxxxxxx>
> You are not calling of_node_put() in the error path. And I don't think
> this even applies.
>
> Patch set to Changes Requested.

Hi Kalle,

Thanks for the reply :)
I will add of_node_put() and send a V2 patch.


Best wishes,
Jia-Ju Bai