> -----Original Message-----
> From: Kalle Valo <kvalo@xxxxxxxxxx>
> Sent: Friday, March 11, 2022 12:38 AM
> To: Pkshih <pkshih@xxxxxxxxxxx>
> Cc: linux-wireless@xxxxxxxxxxxxxxx
> Subject: Re: [PATCH v2 10/13] rtw89: 8852c: add chip::dle_mem
>
> Ping-Ke Shih <pkshih@xxxxxxxxxxx> writes:
>
> > These tables are used to configure hardware buffer size according to
> > operating mode.
> >
> > Signed-off-by: Ping-Ke Shih <pkshih@xxxxxxxxxxx>
> > ---
> > drivers/net/wireless/realtek/rtw89/core.h | 1 +
> > drivers/net/wireless/realtek/rtw89/mac.c | 62 +++++++++++++++++++
> > drivers/net/wireless/realtek/rtw89/mac.h | 10 +++
> > drivers/net/wireless/realtek/rtw89/reg.h | 1 +
> > drivers/net/wireless/realtek/rtw89/rtw8852c.c | 12 ++++
> > 5 files changed, 86 insertions(+)
> >
> > diff --git a/drivers/net/wireless/realtek/rtw89/core.h b/drivers/net/wireless/realtek/rtw89/core.h
> > index 2dc19b530db62..207ac7e605691 100644
> > --- a/drivers/net/wireless/realtek/rtw89/core.h
> > +++ b/drivers/net/wireless/realtek/rtw89/core.h
> > @@ -2168,6 +2168,7 @@ struct rtw89_ple_quota {
> > u16 bb_rpt;
> > u16 wd_rel;
> > u16 cpu_io;
> > + u16 tx_rpt;
> > };
> >
> > struct rtw89_dle_mem {
> > diff --git a/drivers/net/wireless/realtek/rtw89/mac.c b/drivers/net/wireless/realtek/rtw89/mac.c
> > index df657df6b1493..0081cfbfea042 100644
> > --- a/drivers/net/wireless/realtek/rtw89/mac.c
> > +++ b/drivers/net/wireless/realtek/rtw89/mac.c
> > @@ -1183,6 +1183,18 @@ const struct rtw89_dle_size rtw89_wde_size4 = {
> > };
> > EXPORT_SYMBOL(rtw89_wde_size4);
> >
> > +/* 8852C DLFW */
> > +const struct rtw89_dle_size rtw89_wde_size18 = {
> > + RTW89_WDE_PG_64, 0, 2048,
> > +};
> > +EXPORT_SYMBOL(rtw89_wde_size18);
> > +
> > +/* 8852C PCIE SCC */
> > +const struct rtw89_dle_size rtw89_wde_size19 = {
> > + RTW89_WDE_PG_64, 3328, 0,
> > +};
> > +EXPORT_SYMBOL(rtw89_wde_size19);
> > +
> > /* PCIE */
> > const struct rtw89_dle_size rtw89_ple_size0 = {
> > RTW89_PLE_PG_128, 1520, 16,
> > @@ -1195,6 +1207,18 @@ const struct rtw89_dle_size rtw89_ple_size4 = {
> > };
> > EXPORT_SYMBOL(rtw89_ple_size4);
> >
> > +/* 8852C DLFW */
> > +const struct rtw89_dle_size rtw89_ple_size18 = {
> > + RTW89_PLE_PG_128, 2544, 16,
> > +};
> > +EXPORT_SYMBOL(rtw89_ple_size18);
> > +
> > +/* 8852C PCIE SCC */
> > +const struct rtw89_dle_size rtw89_ple_size19 = {
> > + RTW89_PLE_PG_128, 1904, 16,
> > +};
> > +EXPORT_SYMBOL(rtw89_ple_size19);
>
> How much memory does does one EXPORT_SYMBOL() take? There are a lot of
> symbols exported now, and some of them have just four values. Wouldn't
> it make more sense to have only one exported structure which contains
> all the smaller structures?
>
> You could consider this as a separate cleanup.
>
An export symbol costs 40 bytes:
original:
text data bss dec hex filename
46165 1386 0 47551 b9bf mac.o
remove one export symbol:
text data bss dec hex filename
46133 1378 0 47511 b997 mac.o
I will cleanup them as your suggestion, and pay attention to further patches.
Thank you.
--
Ping-Ke
