On 2/25/2022 2:54 AM, Ilpo Järvinen wrote:
On Wed, 23 Feb 2022, Ricardo Martinez wrote:
...
+/**
+ * t7xx_cldma_send_skb() - Send control data to modem.
+ * @md_ctrl: CLDMA context structure.
+ * @qno: Queue number.
+ * @skb: Socket buffer.
+ *
+ * Return:
...
+ * * -EBUSY - Resource lock failure.
Leftover?
This function can still return -EBUSY if
t7xx_pci_sleep_disable_complete() fails.
Maybe returning -ETIMED would make more sense based on the
implementation of t7xx_pci_sleep_disable_complete().
...with those addressed
Reviewed-by: Ilpo Järvinen <ilpo.jarvinen@xxxxxxxxxxxxxxx>
And kudos for rx_not_done -> pending_rx_int change. It was a minor
thing for me but the logic is so much easier to understand now with
that better name :-).
Some other nice cleanups compared with v4 also noted.
