On Wed, 23 Feb 2022, Ricardo Martinez wrote:
> From: Chandrashekar Devegowda <chandrashekar.devegowda@xxxxxxxxx>
>
> Adds AT and MBIM ports to the port proxy infrastructure.
> The initialization method is responsible for creating the corresponding
> ports using the WWAN framework infrastructure. The implemented WWAN port
> operations are start, stop, and TX.
>
> Signed-off-by: Chandrashekar Devegowda <chandrashekar.devegowda@xxxxxxxxx>
> Co-developed-by: Ricardo Martinez <ricardo.martinez@xxxxxxxxxxxxxxx>
> Signed-off-by: Ricardo Martinez <ricardo.martinez@xxxxxxxxxxxxxxx>
>
> >From a WWAN framework perspective:
> Reviewed-by: Loic Poulain <loic.poulain@xxxxxxxxxx>
> ---
> +static int t7xx_port_ctrl_tx(struct wwan_port *port, struct sk_buff *skb)
> +{
...
> + if (!len || !port_private->rx_length_th || !port_private->chan_enable)
It raises eyebrows to see rx_xx being used on something called "tx".
Is it trying to tests port not inited?
--
i.
