Kalle Valo <kvalo@xxxxxxxxxx> writes: > Kalle Valo <kvalo@xxxxxxxxxx> writes: > >> Carl Huang <quic_cjhuang@xxxxxxxxxxx> wrote: >> >>> Implement basic WoW functionalities such as magic-packet, disconnect >>> and pattern. The logic is very similar to ath10k. >>> >>> When WoW is configured, ath11k_core_suspend and ath11k_core_resume >>> are skipped as WoW configuration and hif suspend/resume are done in >>> ath11k_wow_op_suspend() and ath11k_wow_op_resume(). >>> >>> Tested-on: QCA6390 hw2.0 PCI WLAN.HST.1.0.1-01740-QCAHSTSWPLZ_V2_TO_X86-1 >>> >>> Signed-off-by: Carl Huang <quic_cjhuang@xxxxxxxxxxx> >>> Signed-off-by: Baochen Qiang <quic_bqiang@xxxxxxxxxxx> >>> Signed-off-by: Wen Gong <quic_wgong@xxxxxxxxxxx> >> >> This patchset adds new warnings: >> >> drivers/net/wireless/ath/ath11k/mac.c:7284:5: warning: no previous >> prototype for 'ath11k_mac_flush_tx_complete' [-Wmissing-prototypes] >> drivers/net/wireless/ath/ath11k/mac.c:7284:5: warning: symbol >> 'ath11k_mac_flush_tx_complete' was not declared. Should it be static? >> drivers/net/wireless/ath/ath11k/mac.c:8218:34: warning: cast to restricted __be64 >> drivers/net/wireless/ath/ath11k/wow.c:409: line length of 98 exceeds 90 columns >> drivers/net/wireless/ath/ath11k/wow.c:527: line length of 96 exceeds 90 columns >> drivers/net/wireless/ath/ath11k/wow.c:528: line length of 92 exceeds 90 columns >> drivers/net/wireless/ath/ath11k/mac.c:8111: line length of 96 exceeds 90 columns >> drivers/net/wireless/ath/ath11k/mac.c:8168: line length of 92 exceeds 90 columns >> drivers/net/wireless/ath/ath11k/mac.c:8188: line length of 92 exceeds 90 columns > > I fixed all these warnings in the pending branch. I also cleaned up debug messages, changed some function names, change ath11k_info() to ath11k_warn() etc. -- https://patchwork.kernel.org/project/linux-wireless/list/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches