On Thursday 17 February 2022 16:04:51 CET Kalle Valo wrote: > Ulf Hansson <ulf.hansson@xxxxxxxxxx> writes: > > On Thu, 17 Feb 2022 at 10:59, Kalle Valo <kvalo@xxxxxxxxxx> wrote: > >> Jerome Pouiller <Jerome.Pouiller@xxxxxxxxxx> writes: > >> > From: Jérôme Pouiller <jerome.pouiller@xxxxxxxxxx> > >> > > >> > Until now, the SDIO quirks are applied directly from the driver. > >> > However, it is better to apply the quirks before driver probing. So, > >> > this patch relocate the quirks in the MMC framework. > >> > >> It would be good to know how this is better, what's the concrete > >> advantage? > > > > The mmc core has a quirk interface for all types of cards > > (eMMC/SD/SDIO), which thus keeps these things from sprinkling to > > drivers. In some cases, the quirk needs to be applied already during > > card initialization, which is earlier than when probing an SDIO func > > driver or the MMC block device driver. > > > > Perhaps it's a good idea to explain a bit about this in the commit message. > > I would add the whole paragraph to the commit log :) Arf, Greg has just pulled this patch into staging-testing. I assume it is too late to change the commit message. -- Jérôme Pouiller