"Jason A. Donenfeld" <Jason@xxxxxxxxx> writes:
> Hardware random number generators are supposed to use the hw_random
> framework. This commit turns ath9k's kthread-based design into a proper
> hw_random driver.
>
> This compiles, but I have no hardware or other ability to determine
> whether it works. I'll leave further development up to the ath9k
> and hw_random maintainers.
>
> Cc: Toke Høiland-Jørgensen <toke@xxxxxxxxxx>
> Cc: Kalle Valo <kvalo@xxxxxxxxxx>
> Cc: Dominik Brodowski <linux@xxxxxxxxxxxxxxxxxxxx>
> Cc: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx>
> Signed-off-by: Jason A. Donenfeld <Jason@xxxxxxxxx>
[...]
> +retry:
> + if (max & ~3UL)
> + bytes_read = ath9k_rng_data_read(sc, buf, max >> 2);
> + if ((max & 3UL) && ath9k_rng_data_read(sc, &word, 1)) {
> + memcpy(buf + bytes_read, &word, max & 3);
> + bytes_read += max & 3;
> + memzero_explicit(&word, sizeof(word));
> + }
> + if (max && unlikely(!bytes_read) && wait) {
> + msleep(ath9k_rng_delay_get(++fail_stats));
> + goto retry;
> }
Wouldn't a while loop be cleaner? With a some kind limit for the number
of loops, to avoid a neverending loop.
--
https://patchwork.kernel.org/project/linux-wireless/list/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
