On 15. 02. 22, 3:31, davidcomponentone@xxxxxxxxx wrote:
From: Yang Guang <yang.guang5@xxxxxxxxxx>
Use the macro 'swap()' defined in 'include/linux/minmax.h' to avoid
opencoding it.
Ah, v2 already. Why do people tend to send versions of patches in an
hours interval? The comment from before few minutes on v1 still holds:
> Why don't you include that file then?
And also I commented on this very same patch sent on Nov 4 2021 (you did
it correctly on the first attempt back then) [1]:
> Why not just use sort() instead of the double loop?
So you even skip reviewers' comments. Not good.
[1]
https://lore.kernel.org/all/0c3acbd4-6ab2-5cc5-6293-54e30093cce2@xxxxxxxxxx/
Reported-by: Zeal Robot <zealci@xxxxxxxxxx>
The mailbox does not seem to exist:
550 5.1.1 User unknown id=620B3CA9.000
So it's pointless to put it here to bother everyone with undeliverable
e-mails.
Signed-off-by: Yang Guang <yang.guang5@xxxxxxxxxx>
Signed-off-by: David Yang <davidcomponentone@xxxxxxxxx>
---
Changes from v1->v2:
- Fix the typo "sort" to "swap"
---
drivers/net/wireless/ath/ath5k/phy.c | 5 +----
1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/drivers/net/wireless/ath/ath5k/phy.c b/drivers/net/wireless/ath/ath5k/phy.c
index 00f9e347d414..08dc12611f8d 100644
--- a/drivers/net/wireless/ath/ath5k/phy.c
+++ b/drivers/net/wireless/ath/ath5k/phy.c
@@ -1562,16 +1562,13 @@ static s16
ath5k_hw_get_median_noise_floor(struct ath5k_hw *ah)
{
s16 sort[ATH5K_NF_CAL_HIST_MAX];
- s16 tmp;
int i, j;
memcpy(sort, ah->ah_nfcal_hist.nfval, sizeof(sort));
for (i = 0; i < ATH5K_NF_CAL_HIST_MAX - 1; i++) {
for (j = 1; j < ATH5K_NF_CAL_HIST_MAX - i; j++) {
if (sort[j] > sort[j - 1]) {
- tmp = sort[j];
- sort[j] = sort[j - 1];
- sort[j - 1] = tmp;
+ swap(sort[j], sort[j - 1]);
}
}
}
Curly braces not needed now.
regards,
--
js
suse labs
