> -----Original Message----- > From: Kalle Valo <kvalo@xxxxxxxxxx> > Sent: Tuesday, February 8, 2022 5:02 PM > To: Larry Finger <Larry.Finger@xxxxxxxxxxxx> > Cc: Pkshih <pkshih@xxxxxxxxxxx>; linux-wireless@xxxxxxxxxxxxxxx > Subject: Re: Funny log entries for rtw88_8821ce > > Larry Finger <Larry.Finger@xxxxxxxxxxxx> writes: > > > From these log entries, I see no reason why there should be a stop-vif > > 412 seconds after the interface is set from disabled to disconnected. > > This cycling does not cause any problems. Perhaps the statements that > > do the logging should be removed. > > I did a quick check on how rtw88 uses rtw_info() and indeed that should > be cleaned up. > > These should be warning or error messages: > > rtw_info(rtwdev, "invalid H2C command format for debug\n"); > rtw_info(rtwdev, "incorrect lna index (%d)\n", lna_idx); > rtw_info(rtwdev, "unsupported tx path 0x%x\n", antenna_tx); > rtw_info(rtwdev, "unsupported rx path 0x%x\n", antenna_rx); > rtw_info(rtwdev, "unsupported tx path 0x%x\n", antenna_tx); > rtw_info(rtwdev, "unsupported rx path 0x%x\n", antenna_rx); > > Not sure if warn or debug, most likely debug: > > rtw_info(rtwdev, "HW scan aborted with code: %d\n", rc); > > These should be debug messages to avoid spamming the logs: > > rtw_info(rtwdev, "start vif %pM on port %d\n", vif->addr, rtwvif->port); > rtw_info(rtwdev, "stop vif %pM on port %d\n", vif->addr, rtwvif->port); > rtw_info(rtwdev, "change vif %pM (%d)->(%d), p2p (%d)->(%d)\n", > rtw_info(rtwdev, "sta %pM joined with macid %d\n", > rtw_info(rtwdev, "sta %pM with macid %d left\n", > rtw_info(rtwdev, "On freq %u to %u, set SAR %d in 1/%lu dBm\n" > > This is ok: > > rtw_info(rtwdev, "Firmware version %u.%u.%u, H2C version %u\n", > I will fix them as well as rtw89. To avoid mistakes, I do google search for KERN_INFO, and find [1] KERN_INFO: this is the log level used for informational messages about the action performed by the kernel. Then, I have a question about the message of setting SAR: rtw_info(rtwdev, "On freq %u to %u, set SAR %d in 1/%lu dBm\n" When a user sets SAR via iw, this message can reflect the action performed by driver. Is this rtw_info acceptable? [1] https://linuxconfig.org/introduction-to-the-linux-kernel-log-levels -- Ping-Ke
