On Tue, 2022-02-01 at 16:35 +0200, Kalle Valo wrote: > Johannes Berg <johannes@xxxxxxxxxxxxxxxx> writes: > > > From: Johannes Berg <johannes.berg@xxxxxxxxx> > > > > My previous fix here to fix the deadlock left a race where > > the exact same deadlock (see the original commit referenced > > below) can still happen if cfg80211_destroy_ifaces() already > > runs while nl80211_netlink_notify() is still marking some > > interfaces as nl_owner_dead. > > > > The race happens because we have two loops here - first we > > dev_close() all the netdevs, and then we destroy them. If we > > also have two netdevs (first one need only be a wdev though) > > then we can find one during the first iteration, close it, > > and go to the second iteration -- but then find two, and try > > to destroy also the one we didn't close yet. > > > > Fix this by only iterating once. > > > > Change-Id: Ie56cd0ef3f0d2108bb8a25c8bb5efced15e6a909 > > You forgot the Change-Id. > Wtf, sorry, guess I sent it from a place with the wrong script. I'll strip it when I apply it, I guess johannes
