Peiwei Hu <jlu.hpw@xxxxxxxxxxx> wrote: > goto fail instead of returning directly in error exiting > > Signed-off-by: Peiwei Hu <jlu.hpw@xxxxxxxxxxx> The commit log does not answer to "why?". Also looking at ipw2100_pci_init_one() I think it would need more cleanup in error handling, for example pci_ionumap() is called in different order etc. Patch set to Changes Requested. -- https://patchwork.kernel.org/project/linux-wireless/patch/tencent_205AA371C910BBA2CF01B311811ABDF2560A@xxxxxx/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
