Search Linux Wireless

Re: [PATCH] mac80211: provide sequence numbers

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sat, 2008-10-11 at 16:49 +0200, Ivo van Doorn wrote:

> >  	if (!ieee80211_is_data_qos(hdr->frame_control)) {
> > +		/* driver should assign sequence number */
> >  		info->flags |= IEEE80211_TX_CTL_ASSIGN_SEQ;
> > +		/* for pure STA mode without beacons, we can do it */
> > +		hdr->seq_ctrl = cpu_to_le16(tx->sdata->sequence_number);
> > +		tx->sdata->sequence_number += 0x10;
> > +		tx->sdata->sequence_number &= IEEE80211_SCTL_SEQ;
> >  		return TX_CONTINUE;
> >  	}
> 
> Shouldn't this be changed to only setting the IEEE80211_TX_CTL_ASSIGN_SEQ
> flag when the sequence counter was _not_ set (with beacons)?

No, if you implement interface modes that beacon then you need to assign
the sequence number for beacons and these frames from a _single_
counter, which then has to be in the hw/firmware/driver. IOW, you have
to override these numbers.

johannes

Attachment: signature.asc
Description: This is a digitally signed message part


[Index of Archives]     [Linux Host AP]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Linux Kernel]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Samba]     [Device Mapper]
  Powered by Linux