On Fri, 2022-01-21 at 13:54 -0300, Luiz Sampaio wrote: > The enum led_brightness, which contains the declaration of LED_OFF, > LED_ON, LED_HALF and LED_FULL is obsolete, as the led class now supports > max_brightness. > https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches and particularly https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches#commit_messages would be a good thing to read. Also, clearly you need to actually sign off your patches: https://www.kernel.org/doc/html/latest/process/submitting-patches.html#developer-s-certificate-of-origin-1-1 (but yeah read the entire page) Anyway, I'm with the other comments - what's the point in replacing things like "LED_FULL" with arbitrary "255". I guess your commit message should explain that, I don't see how it really is so obviously "obsolete" that this needs no more comments. johannes
