19.01.2022 20:49, Andy Shevchenko пишет:
> On Mon, Jan 17, 2022 at 4:30 PM Hector Martin <marcan@xxxxxxxxx> wrote:
>>
>> This avoids leaking memory if brcmf_chip_get_raminfo fails. Note that
>> the CLM blob is released in the device remove path.
>
> ...
>
>> if (ret) {
>
>> brcmf_err(bus, "Failed to get RAM info\n");
>> + release_firmware(fw);
>> + brcmf_fw_nvram_free(nvram);
>
> Can we first undo the things and only after print a message?
Having message first usually is more preferred because at minimum you'll
get the message if "undoing the things" crashes, i.e. will be more
obvious what happened.
