On 05/01/2022 04.46, Arend Van Spriel wrote: > On January 4, 2022 8:30:51 AM Hector Martin <marcan@xxxxxxxxx> wrote: > >> This new API version is required for at least the BCM4387 firmware. Add >> support for it, with a fallback to the v1 API. >> >> Acked-by: Linus Walleij <linus.walleij@xxxxxxxxxx> >> Signed-off-by: Hector Martin <marcan@xxxxxxxxx> >> --- >> .../broadcom/brcm80211/brcmfmac/cfg80211.c | 113 ++++++++++++++---- >> .../broadcom/brcm80211/brcmfmac/feature.c | 1 + >> .../broadcom/brcm80211/brcmfmac/feature.h | 4 +- >> .../broadcom/brcm80211/brcmfmac/fwil_types.h | 49 +++++++- >> 4 files changed, 145 insertions(+), 22 deletions(-) > > Compiling this patch with C=2 gives following warnings: > > drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c:1086:28: > warning: incorrect type in assignment (different base types) > drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c:1086:28: > expected restricted __le16 [usertype] version > drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c:1086:28: got int > drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c:1148:38: > warning: incorrect type in assignment (different base types) > drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c:1148:38: > expected restricted __le32 [usertype] scan_type > drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c:1148:38: got int > drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c:789:30: > warning: incorrect type in assignment (different base types) > drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c:789:30: > expected unsigned char [usertype] scan_type > drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c:789:30: got > restricted __le32 [usertype] scan_type > > Will check if this is a valid warning. Those are valid bugs (it'd break on big endian platforms), thanks for checking this. Fixed for v3 :) -- Hector Martin (marcan@xxxxxxxxx) Public Key: https://mrcn.st/pub
