On Sun, 2022-01-16 at 13:43 +0100, Lorenzo Bianconi wrote: > Move HE radiotap parsing code in mt76-connac module since it is > shared > between mt7921 and mt7915 drivers. > > Signed-off-by: Lorenzo Bianconi <lorenzo@xxxxxxxxxx> > --- > .../net/wireless/mediatek/mt76/mt76_connac.h | 2 + > .../wireless/mediatek/mt76/mt76_connac_mac.c | 168 ++++++++++++++++ > .../wireless/mediatek/mt76/mt76_connac_mac.h | 4 + > .../net/wireless/mediatek/mt76/mt7915/mac.c | 175 +--------------- > - [...] > +mt76_connac_mac_decode_he_mu_radiotap(struct sk_buff *skb, __le32 > *rxv) > +{ > + struct mt76_rx_status *status = (struct mt76_rx_status *)skb- > >cb; > + static const struct ieee80211_radiotap_he_mu mu_known = { > + .flags1 = HE_BITS(MU_FLAGS1_SIG_B_MCS_KNOWN) | > + HE_BITS(MU_FLAGS1_SIG_B_DCM_KNOWN) | > + HE_BITS(MU_FLAGS1_CH1_RU_KNOWN) | > + HE_BITS(MU_FLAGS1_SIG_B_SYMS_USERS_KNOWN) | > + HE_BITS(MU_FLAGS1_SIG_B_COMP_KNOWN), > + .flags2 = HE_BITS(MU_FLAGS2_BW_FROM_SIG_A_BW_KNOWN) | > + HE_BITS(MU_FLAGS2_PUNC_FROM_SIG_A_BW_KNOWN), I think hardware doesn't report MU_FLAGS2_PUNC_FROM_SIG_A_BW_KNOWN and MU_FLAGS1_SIG_B_COMP_KNOWN. Should align mt7915 here. Ryder