Hi Reviewers, On this patch I have a kernel bot warning, which I intend to fix along with all the comments and discussion and push out V3. So, any comments/next steps are appreciated. Thanks Abhishek On Mon, Jan 10, 2022 at 5:08 PM kernel test robot <lkp@xxxxxxxxx> wrote: > > Hi Abhishek, > > Thank you for the patch! Perhaps something to improve: > > [auto build test WARNING on kvalo-ath/ath-next] > [also build test WARNING on kvalo-wireless-drivers-next/master kvalo-wireless-drivers/master v5.16 next-20220110] > [If your patch is applied to the wrong git tree, kindly drop us a note. > And when submitting patch, we suggest to use '--base' as documented in > https://git-scm.com/docs/git-format-patch] > > url: https://github.com/0day-ci/linux/commits/Abhishek-Kumar/ath10k-search-for-default-BDF-name-provided-in-DT/20220111-071636 > base: https://git.kernel.org/pub/scm/linux/kernel/git/kvalo/ath.git ath-next > config: arc-allyesconfig (https://download.01.org/0day-ci/archive/20220111/202201110851.5qAxfQJj-lkp@xxxxxxxxx/config) > compiler: arceb-elf-gcc (GCC) 11.2.0 > reproduce (this is a W=1 build): > wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross > chmod +x ~/bin/make.cross > # https://github.com/0day-ci/linux/commit/50c4c7cb02cc786afcd9aff27616a6e20296c703 > git remote add linux-review https://github.com/0day-ci/linux > git fetch --no-tags linux-review Abhishek-Kumar/ath10k-search-for-default-BDF-name-provided-in-DT/20220111-071636 > git checkout 50c4c7cb02cc786afcd9aff27616a6e20296c703 > # save the config file to linux build tree > mkdir build_dir > COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.2.0 make.cross O=build_dir ARCH=arc SHELL=/bin/bash drivers/net/wireless/ath/ath10k/ > > If you fix the issue, kindly add following tag as appropriate > Reported-by: kernel test robot <lkp@xxxxxxxxx> > > All warnings (new ones prefixed by >>): > > drivers/net/wireless/ath/ath10k/core.c: In function 'ath10k_core_parse_default_bdf_dt': > >> drivers/net/wireless/ath/ath10k/core.c:1103:116: warning: format '%ld' expects argument of type 'long int', but argument 4 has type 'unsigned int' [-Wformat=] > 1103 | "default board name is longer than allocated buffer, board_name: %s; allocated size: %ld\n", > | ~~^ > | | > | long int > | %d > 1104 | board_name, sizeof(ar->id.default_bdf)); > | ~~~~~~~~~~~~~~~~~~~~~~~~~~ > | | > | unsigned int > > > vim +1103 drivers/net/wireless/ath/ath10k/core.c > > 1083 > 1084 int ath10k_core_parse_default_bdf_dt(struct ath10k *ar) > 1085 { > 1086 struct device_node *node; > 1087 const char *board_name = NULL; > 1088 > 1089 ar->id.default_bdf[0] = '\0'; > 1090 > 1091 node = ar->dev->of_node; > 1092 if (!node) > 1093 return -ENOENT; > 1094 > 1095 of_property_read_string(node, "qcom,ath10k-default-bdf", > 1096 &board_name); > 1097 if (!board_name) > 1098 return -ENODATA; > 1099 > 1100 if (strscpy(ar->id.default_bdf, > 1101 board_name, sizeof(ar->id.default_bdf)) < 0) > 1102 ath10k_warn(ar, > > 1103 "default board name is longer than allocated buffer, board_name: %s; allocated size: %ld\n", > 1104 board_name, sizeof(ar->id.default_bdf)); > 1105 > 1106 return 0; > 1107 } > 1108 EXPORT_SYMBOL(ath10k_core_parse_default_bdf_dt); > 1109 > > --- > 0-DAY CI Kernel Test Service, Intel Corporation > https://lists.01.org/hyperkitty/list/kbuild-all@xxxxxxxxxxxx
