On Thu, 2022-01-13 at 12:47 +0200, Kalle Valo wrote: > Luca Coelho <luca@xxxxxxxxx> writes: > > > From: Luca Coelho <luciano.coelho@xxxxxxxxx> > > > > Older hardware, for instance 3160, do not support SAR GEO offsets. We > > used to check for support before sending the command, but when moving > > the command to the init phase, we lost the check. This causes a > > failure when initializing HW that do not support this command. > > > > Fix that by adding a check before sending the command. Additionally, > > fix the caller so that it checks for the return value of the > > iwl_mvm_sar_geo_init() function, which it was ignoring. > > > > Fixes: db700bc35703 ("iwlwifi: mvm: check if SAR GEO is supported before sending command") > > $ git show db700bc35703 > fatal: ambiguous argument 'db700bc35703': unknown revision or path not in the working tree. > > No need to resend because of this, if you can provide the commit id I > can fix the tag. Oops, sorry, I added the tag to my own commit... This is the correct one: Fixes: 78a19d5285d9 ("iwlwifi: mvm: Read the PPAG and SAR tables at INIT stage") -- Luca.