Search Linux Wireless

Re: [PATCH v2 3/5] mt76: mt7915: add support for MT7986

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



> On Wed, 2022-01-12 at 14:35 +0100, Lorenzo Bianconi wrote:
> > > 
> > > @@ -302,6 +316,15 @@ struct mt7915_dev {
> > >  		u8 table_mask;
> > >  		u8 n_agrt;
> > >  	} twt;
> > > +
> > > +	struct reset_control *rstc;
> > > +	void __iomem *dcm;
> > > +	void __iomem *sku;
> > > +
> > > +	struct {
> > > +		bool is_7975;
> > > +		bool is_7976;
> > > +	} adie[MT7986_MAX_ADIE_NUM];
> > 
> > do we really need it? Can we just read data from chip when necessary?
> > it is not
> > access in the hot-path, right?
> > I think it is easier and more readable.
> 
> Adie registers are inaccessible after wfsys power on so we need some
> places to store chip configuration.
> We will modify it to make it more readable.
> + u32 adie;

what I mean is just continue reading these values after the first time (that is
in common for both approaches).

Regards,
Lorenzo

> 
> thanks,
> Peter
> 

Attachment: signature.asc
Description: PGP signature


[Index of Archives]     [Linux Host AP]     [ATH6KL]     [Linux Wireless Personal Area Network]     [Linux Bluetooth]     [Wireless Regulations]     [Linux Netdev]     [Kernel Newbies]     [Linux Kernel]     [IDE]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite Hiking]     [MIPS Linux]     [ARM Linux]     [Linux RAID]

  Powered by Linux