On Fri, Oct 10, 2008 at 3:28 PM, Johannes Berg <johannes@xxxxxxxxxxxxxxxx> wrote: > On Fri, 2008-10-10 at 14:45 +0200, Tomas Winkler wrote: >> On Fri, Oct 10, 2008 at 11:11 AM, Johannes Berg >> <johannes@xxxxxxxxxxxxxxxx> wrote: >> > sta_id = iwl_get_ra_sta_id(priv, hdr); >> > if (txq->sched_retry && unlikely(sta_id == IWL_INVALID_STATION)) { >> > IWL_ERROR("Station not known\n"); >> > return; >> > } >> > >> > if (txq->sched_retry) { >> > [...] >> > } else { >> > [...] >> > if (index != -1) { >> > int freed = iwl_tx_queue_reclaim(priv, txq_id, index); >> > if (tid != MAX_TID_COUNT) >> > priv->stations[sta_id].tid[tid].tfds_in_queue -= freed; >> > [...] >> > >> > >> > priv->stations has 32 entries, IWL_INVALID_STATION is 255. >> >> Don't see a problem this is what iwl_find_station returns if it cannot find > > The last line I quoted uses the sta_id regardless of what was returned. Thanks, I'll check if this is a problem also in new code. Tomas -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html