Wen Gong <quic_wgong@xxxxxxxxxxx> wrote: > In function ath10k_wow_convert_8023_to_80211(), it will do memcpy for > the new->pattern, and currently the new->pattern and new->mask is same > with the old, then the memcpy of new->pattern will also overwrite the > old->pattern, because the header format of new->pattern is 802.11, > its length is larger than the old->pattern which is 802.3. Then the > operation of "Copy frame body" will copy a mistake value because the > body memory has been overwrite when memcpy the new->pattern. > > Assign another empty value to new_pattern to avoid the overwrite issue. > > Tested-on: QCA6174 hw3.2 SDIO WLAN.RMH.4.4.1-00049 > > Fixes: fa3440fa2fa1 ("ath10k: convert wow pattern from 802.3 to 802.11") > Signed-off-by: Wen Gong <quic_wgong@xxxxxxxxxxx> > Signed-off-by: Kalle Valo <quic_kvalo@xxxxxxxxxxx> Patch applied to ath-next branch of ath.git, thanks. e3fb3d4418fc ath10k: fix memory overwrite of the WoWLAN wakeup packet pattern -- https://patchwork.kernel.org/project/linux-wireless/patch/20211222031347.25463-1-quic_wgong@xxxxxxxxxxx/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches