Hector Martin <marcan@xxxxxxxxx> writes: > On 04/01/2022 23.12, Andy Shevchenko wrote: >> On Tue, Jan 4, 2022 at 9:29 AM Hector Martin <marcan@xxxxxxxxx> wrote: >>> >>> The driver was enabling IRQs before the message processing was >>> initialized. This could cause IRQs to come in too early and crash the >>> driver. Instead, move the IRQ enable and hostready to a bus preinit >>> function, at which point everything is properly initialized. >>> >>> Fixes: 9e37f045d5e7 ("brcmfmac: Adding PCIe bus layer support.") >> >> You should gather fixes at the beginning of the series, and even >> possible to send them as a separate series. In the current state it's >> unclear if there are dependencies on your new feature (must not be for >> fixes that meant to be backported). >> > > Thanks, I wasn't sure what order you wanted those in. I'll put them at > the top for v3. I think none of those should have any dependencies on > the rest of the patches, modulo some trivial rebase wrangling. If there are no dependencies, please send the brcmfmac fixes separately so that I can apply them earlier. -- https://patchwork.kernel.org/project/linux-wireless/list/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches