Hi Jakub, I love your patch! Yet something to improve: [auto build test ERROR on bpf-next/master] url: https://github.com/0day-ci/linux/commits/Jakub-Kicinski/net-don-t-include-filter-h-from-net-sock-h/20211229-032712 base: https://git.kernel.org/pub/scm/linux/kernel/git/bpf/bpf-next.git master config: i386-randconfig-m021-20211228 (https://download.01.org/0day-ci/archive/20211229/202112290523.IciwiUz8-lkp@xxxxxxxxx/config) compiler: gcc-9 (Debian 9.3.0-22) 9.3.0 reproduce (this is a W=1 build): # https://github.com/0day-ci/linux/commit/655ad46a9ed1d3185292e9e8e545887d781d06d7 git remote add linux-review https://github.com/0day-ci/linux git fetch --no-tags linux-review Jakub-Kicinski/net-don-t-include-filter-h-from-net-sock-h/20211229-032712 git checkout 655ad46a9ed1d3185292e9e8e545887d781d06d7 # save the config file to linux build tree mkdir build_dir make W=1 O=build_dir ARCH=i386 SHELL=/bin/bash If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot <lkp@xxxxxxxxx> All errors (new ones prefixed by >>): net/ipv6/ip6_fib.c: In function 'fib6_add': net/ipv6/ip6_fib.c:1377:25: warning: variable 'pn' set but not used [-Wunused-but-set-variable] 1377 | struct fib6_node *fn, *pn = NULL; | ^~ net/ipv6/ip6_fib.c: In function 'ipv6_route_prog_seq_show': >> net/ipv6/ip6_fib.c:2665:9: error: implicit declaration of function 'bpf_iter_run_prog' [-Werror=implicit-function-declaration] 2665 | return bpf_iter_run_prog(prog, &ctx); | ^~~~~~~~~~~~~~~~~ net/ipv6/ip6_fib.c: In function 'ipv6_route_seq_show': >> net/ipv6/ip6_fib.c:2671:23: error: storage size of 'meta' isn't known 2671 | struct bpf_iter_meta meta; | ^~~~ >> net/ipv6/ip6_fib.c:2676:9: error: implicit declaration of function 'bpf_iter_get_info' [-Werror=implicit-function-declaration] 2676 | prog = bpf_iter_get_info(&meta, false); | ^~~~~~~~~~~~~~~~~ net/ipv6/ip6_fib.c:2671:23: warning: unused variable 'meta' [-Wunused-variable] 2671 | struct bpf_iter_meta meta; | ^~~~ net/ipv6/ip6_fib.c: In function 'ipv6_route_seq_stop': net/ipv6/ip6_fib.c:2688:23: error: storage size of 'meta' isn't known 2688 | struct bpf_iter_meta meta; | ^~~~ net/ipv6/ip6_fib.c:2688:23: warning: unused variable 'meta' [-Wunused-variable] cc1: some warnings being treated as errors vim +/bpf_iter_run_prog +2665 net/ipv6/ip6_fib.c 8d2ca1d7b5c3e6 Hannes Frederic Sowa 2013-09-21 2655 138d0be35b141e Yonghong Song 2020-05-09 2656 #if IS_BUILTIN(CONFIG_IPV6) && defined(CONFIG_BPF_SYSCALL) 138d0be35b141e Yonghong Song 2020-05-09 2657 static int ipv6_route_prog_seq_show(struct bpf_prog *prog, 138d0be35b141e Yonghong Song 2020-05-09 2658 struct bpf_iter_meta *meta, 138d0be35b141e Yonghong Song 2020-05-09 2659 void *v) 138d0be35b141e Yonghong Song 2020-05-09 2660 { 138d0be35b141e Yonghong Song 2020-05-09 2661 struct bpf_iter__ipv6_route ctx; 138d0be35b141e Yonghong Song 2020-05-09 2662 138d0be35b141e Yonghong Song 2020-05-09 2663 ctx.meta = meta; 138d0be35b141e Yonghong Song 2020-05-09 2664 ctx.rt = v; 138d0be35b141e Yonghong Song 2020-05-09 @2665 return bpf_iter_run_prog(prog, &ctx); 138d0be35b141e Yonghong Song 2020-05-09 2666 } 138d0be35b141e Yonghong Song 2020-05-09 2667 138d0be35b141e Yonghong Song 2020-05-09 2668 static int ipv6_route_seq_show(struct seq_file *seq, void *v) 138d0be35b141e Yonghong Song 2020-05-09 2669 { 138d0be35b141e Yonghong Song 2020-05-09 2670 struct ipv6_route_iter *iter = seq->private; 138d0be35b141e Yonghong Song 2020-05-09 @2671 struct bpf_iter_meta meta; 138d0be35b141e Yonghong Song 2020-05-09 2672 struct bpf_prog *prog; 138d0be35b141e Yonghong Song 2020-05-09 2673 int ret; 138d0be35b141e Yonghong Song 2020-05-09 2674 138d0be35b141e Yonghong Song 2020-05-09 2675 meta.seq = seq; 138d0be35b141e Yonghong Song 2020-05-09 @2676 prog = bpf_iter_get_info(&meta, false); 138d0be35b141e Yonghong Song 2020-05-09 2677 if (!prog) 138d0be35b141e Yonghong Song 2020-05-09 2678 return ipv6_route_native_seq_show(seq, v); 138d0be35b141e Yonghong Song 2020-05-09 2679 138d0be35b141e Yonghong Song 2020-05-09 2680 ret = ipv6_route_prog_seq_show(prog, &meta, v); 138d0be35b141e Yonghong Song 2020-05-09 2681 iter->w.leaf = NULL; 138d0be35b141e Yonghong Song 2020-05-09 2682 138d0be35b141e Yonghong Song 2020-05-09 2683 return ret; 138d0be35b141e Yonghong Song 2020-05-09 2684 } 138d0be35b141e Yonghong Song 2020-05-09 2685 --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-all@xxxxxxxxxxxx
