On 12/25/2021 9:45 AM, Andy Shevchenko wrote:
On Sat, Dec 25, 2021 at 1:41 AM Florian Fainelli <f.fainelli@xxxxxxxxx> wrote:
The BCMA devices include the brcmnand controller but they do not wire up
any interrupt line, allow the main interrupt to be optional and update
the completion path to also check for the lack of an interrupt line.
Signed-off-by: Florian Fainelli <f.fainelli@xxxxxxxxx>
- unsigned int irq;
+ int irq;
instead.,,
+ ctrl->irq = platform_get_irq_optional(pdev, 0);
+ if (ctrl->irq >= 0) {
ret = ...
if (ret > 0) {
And drop 0 from the equation, OF never uses 0 as valid vIRQ.
OK but the point of this patch series is to allow the use of the
brcmnand driver in a configuration without OF. I don't really see the
point in continuing to use unsigned int instead of just letting
request_irq() play through and tell us if the interrupt descriptor was
valid later on.
--
Florian
