Search Linux Wireless

Re: [RFC PATCH] rtl8187: do not report ACKs if USB Tx status is non-zero

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Oct 08, 2008 at 09:38:49PM +0200, Stefanik Gábor wrote:

> Another weird thing: the code above essentially attempts to do this:
> Wait for an ACK
> If not TX_CTL_NO_ACK:
>    If acked:
>       Report the packet as acked.
>    Endif
>    If no ACK until timeout:
>       Report packet as unacked
>    Endif
> Endif
> 
> This would be better, as it doesn't waste time waiting for an ACK for
> unacked frames:
> 
> If not TX_CTL_NO_ACK:
> Wait for an ACK
>    If acked:
>       Report the packet as acked.
>    Endif
>    If no ACK until timeout:
>       Report packet as unacked
>    Endif
> Endif
> 
> Of course, this only works if "Wait for an ACK" actually works.

Well as I understand it, the only waiting is related to the URB
submission (which is asynchronous anyway).  I don't really see how
we could avoid it.

John
-- 
John W. Linville		Linux should be at the core
linville@xxxxxxxxxxxxx			of your literate lifestyle.
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Host AP]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Linux Kernel]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Samba]     [Device Mapper]
  Powered by Linux