Luca Coelho <luca@xxxxxxxxx> writes: > On Mon, 2021-12-13 at 12:49 +0200, Kalle Valo wrote: >> Luca Coelho <luca@xxxxxxxxx> writes: >> >> > From: Johannes Berg <johannes.berg@xxxxxxxxx> >> > >> > On a 32-bit build, the division here needs to be done >> > using do_div(), otherwise the compiler will try to call >> > a function that doesn't exist, thus failing to build. >> > >> > Signed-off-by: Johannes Berg <johannes.berg@xxxxxxxxx> >> > Signed-off-by: Luca Coelho <luciano.coelho@xxxxxxxxx> >> >> Fixes tag? And should this go to wireless-drivers? > > I just checked the patch that this claims to fix internally and it's > rather old. It went into v5.10: > > commit b68bd2e3143adbcbc7afd2bc4974c1b988b87211 > Author: Ilan Peer <ilan.peer@xxxxxxxxx> > AuthorDate: Wed Sep 30 16:31:12 2020 +0300 > Commit: Luca Coelho <luciano.coelho@xxxxxxxxx> > CommitDate: Thu Oct 1 22:00:55 2020 +0300 > > iwlwifi: mvm: Add FTM initiator RTT smoothing logic > > > So, if nobody caught this before, I think neither a Fixes tag nor > taking it to wireless-drivers is necessary. > > What do you think? Weird that nobody else has reported it, maybe people don't test 32-bit builds that much anymore? But I would prefer to have a Fixes tag, makes it easier for backporters. -- https://patchwork.kernel.org/project/linux-wireless/list/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
