Search Linux Wireless

Re: [PATCH 3/6] ath11k: implement hw data filter

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Carl Huang <cjhuang@xxxxxxxxxxxxxx> writes:

> Host needs to set hw data filter before entering WoW to
> let firmware drop needless bc/mc frames to avoid frequent wakeup.
> Host clears hw data filter when leaving WoW.
>
> Tested-on: QCA6390 hw2.0 PCI WLAN.HST.1.0.1-01740-QCAHSTSWPLZ_V2_TO_X86-1
>
> Signed-off-by: Carl Huang <cjhuang@xxxxxxxxxxxxxx>

[...]

> @@ -598,8 +647,14 @@ int ath11k_wow_op_resume(struct ieee80211_hw *hw)
>  	}
>  
>  	ret = ath11k_wow_nlo_cleanup(ar);
> -	if (ret)
> +	if (ret) {
>  		ath11k_warn(ar->ab, "failed to cleanup nlo: %d\n", ret);
> +		goto exit;
> +	}
> +
> +	ret = ath11k_wow_clear_hw_filter(ar);
> +	if (ret)
> +		ath11k_warn(ar->ab, "failed to clear hw filter: %d\n", ret);
>  
>  exit:
>  	if (ret) {

For consistency please add goto exit for ath11k_wow_clear_hw_filter().

-- 
https://patchwork.kernel.org/project/linux-wireless/list/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches



[Index of Archives]     [Linux Host AP]     [ATH6KL]     [Linux Wireless Personal Area Network]     [Linux Bluetooth]     [Wireless Regulations]     [Linux Netdev]     [Kernel Newbies]     [Linux Kernel]     [IDE]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite Hiking]     [MIPS Linux]     [ARM Linux]     [Linux RAID]

  Powered by Linux