Ping-Ke Shih <pkshih@xxxxxxxxxxx> wrote: > This is found by Smatch static checker warning: > drivers/net/wireless/realtek/rtw89/mac80211.c:31 rtw89_ops_tx() > error: uninitialized symbol 'qsel'. > > The warning is because 'qsel' isn't filled by rtw89_core_tx_write() due to > failed to write. The way to fix it is to avoid kicking off TX DMA, so add > 'return' to the failure case. > > Reported-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx> > Signed-off-by: Ping-Ke Shih <pkshih@xxxxxxxxxxx> Patch applied to wireless-drivers-next.git, thanks. a58fdb7c843a rtw89: don't kick off TX DMA if failed to write skb -- https://patchwork.kernel.org/project/linux-wireless/patch/20211201093816.13806-1-pkshih@xxxxxxxxxxx/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
