Re: [PATCH] brcmfmac: Fix incorrect type assignments for keep-alive

Arend van Spriel <arend.vanspriel@xxxxxxxxxxxx> · Wed, 8 Dec 2021 14:37:28 +0100

On 12/8/2021 9:55 AM, Loic Poulain wrote:
cpu_to_le16 has been used for all keep-alive fields, but 'perdio_msec'
is a 32-bit field and 'keep_alive_id' a 8-bit one. Fix that.

Fixes: 7a6cfe28ae3e ("brcmfmac:  Configure keep-alive packet on suspend")
Reported-by: kernel test robot <lkp@xxxxxxxxx>
Signed-off-by: Loic Poulain <loic.poulain@xxxxxxxxxx>
---
  drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c | 4 ++--
  1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c
index 1679361..ba52318 100644
--- a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c
+++ b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c
@@ -3908,9 +3908,9 @@ static int brcmf_keepalive_start(struct brcmf_if *ifp, unsigned int interval)

missed it in original patch, but prefer u32 typed.

  
  	/* Configure Null function/data keepalive */
  	kalive.version = cpu_to_le16(1);
-	kalive.period_msec = cpu_to_le16(interval * MSEC_PER_SEC);
+	kalive.period_msec = cpu_to_le32(interval * MSEC_PER_SEC);

should we check whether multiplication (interval * MSEC_PER_SEC) does 
not overflow 32 bits? The only caller now uses 30 as interval so that is 
fine.

Regards,
Arend
Attachment:
smime.p7s

Description: S/MIME Cryptographic Signature




