On Tue, 2021-12-07 at 14:25 +0100, Arnd Bergmann wrote: > > > config IWLMEI > > > - tristate "Intel Management Engine communication over WLAN" > > > - depends on INTEL_MEI > > > + bool "Intel Management Engine communication over WLAN" > > > + depends on INTEL_MEI=y || INTEL_MEI=IWLMVM > > > + depends on IWLMVM=y || IWLWIFI=m > > > depends on PM > > > - depends on IWLMVM > > > help > > > Enables the iwlmei kernel module. > > > > Johannes suggested to make IWLMVM depend on IWLMEI || !IWLMEI > > That worked as well, I just had issues with this in our internal backport based tree. > > I need to spend a bit more time on this, but I admit my total ignorance in Kconfig's dialect. > > It's still not enough, the dependency is in iwlwifi, not in iwlmvm, so it > would remain broken for IWLWIFI=y IWLMVM=m IWLMEI=m. > I missed the pcie/trans.c dependency, and the others are (I think) in mvm... but then we can do config IWLWIFI ... depends on IWLMEI || !IWLMEI ... no? That way, we exclude IWLWIFI=y && IWLMEI=m, which I believe causes the issue? And IWLMVM already depends on IWLWIFI (via the if clause), so that johannes
