Kees Cook <keescook@xxxxxxxxxxxx> wrote: > In preparation for FORTIFY_SOURCE performing compile-time and run-time > field bounds checking for memcpy(), memmove(), and memset(), avoid > intentionally writing across neighboring fields. > > Use named struct in struct mwl8k_cmd_set_key around members key_material, > tkip_tx_mic_key, and tkip_rx_mic_key so they can be referenced > together. This will allow memcpy() and sizeof() to more easily reason > about sizes, improve readability, and avoid future warnings about writing > beyond the end of key_material. > > "pahole" shows no size nor member offset changes to struct > mwl8k_cmd_set_key. "objdump -d" shows no object code changes. > > Signed-off-by: Kees Cook <keescook@xxxxxxxxxxxx> Patch applied to wireless-drivers-next.git, thanks. f01b3774309f mwl8k: Use named struct for memcpy() region -- https://patchwork.kernel.org/project/linux-wireless/patch/20211119004905.2348143-1-keescook@xxxxxxxxxxxx/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
