> -----Original Message----- > From: kvalo=codeaurora.org@xxxxxxxxxxxxxxxxx <kvalo=codeaurora.org@xxxxxxxxxxxxxxxxx> On Behalf Of Kalle > Valo > Sent: Saturday, November 27, 2021 12:20 AM > To: yhchuang@xxxxxxxxxxx > Cc: linux-wireless@xxxxxxxxxxxxxxx; briannorris@xxxxxxxxxxxx > Subject: Re: [PATCH] rtw88: add debugfs to fix tx rate > > <yhchuang@xxxxxxxxxxx> wrote: > > > From: Yan-Hsuan Chuang <yhchuang@xxxxxxxxxxx> > > > > It is useful to fix the bit rate of TX packets. For example, if > > someone is measuring the TX power, or debugging with the issues > > of the TX throughput on the field. > > > > To set the value of fixed rate, one should input corresponding > > desc rate index (ex, 0x0b for DESC_RATE54M to fix at 54 Mbps). > > Set a value larger than DESC_RATE_MAX will disable fix rate, so > > the rate adaptive mechanism can resume to work. > > > > Example, > > To fix rate at MCS 1: > > echo 0x0d > /sys/kernel/debug/ieee80211/phy0/rtw88/fix_rate > > > > To not to fix rate: > > echo 0xff > /sys/kernel/debug/ieee80211/phy0/rtw88/fix_rate > > > > To know which rate was fixed at: > > cat /sys/kernel/debug/ieee80211/phy0/rtw88/fix_rate > > > > Signed-off-by: Yan-Hsuan Chuang <yhchuang@xxxxxxxxxxx> > > Reviewed-by: Brian Norris <briannorris@xxxxxxxxxxxx> > > Tested-by: Brian Norris <briannorris@xxxxxxxxxxxx> > > So the concensus was that doing this from debugfs is ok, but > unfortunately this doesn't apply anymore. Please respin. > > Recorded preimage for 'drivers/net/wireless/realtek/rtw88/tx.c' > error: Failed to merge in the changes. > hint: Use 'git am --show-current-patch' to see the failed patch > Applying: rtw88: add debugfs to fix tx rate > Using index info to reconstruct a base tree... > M drivers/net/wireless/realtek/rtw88/debug.c > M drivers/net/wireless/realtek/rtw88/main.c > M drivers/net/wireless/realtek/rtw88/main.h > M drivers/net/wireless/realtek/rtw88/tx.c > Falling back to patching base and 3-way merge... > Auto-merging drivers/net/wireless/realtek/rtw88/tx.c > CONFLICT (content): Merge conflict in drivers/net/wireless/realtek/rtw88/tx.c > Auto-merging drivers/net/wireless/realtek/rtw88/main.h > Auto-merging drivers/net/wireless/realtek/rtw88/main.c > Auto-merging drivers/net/wireless/realtek/rtw88/debug.c > Patch failed at 0001 rtw88: add debugfs to fix tx rate > > Patch set to Changes Requested. > I have done rebase and sent out. Thank you [1] https://lore.kernel.org/linux-wireless/20211129020506.6273-1-pkshih@xxxxxxxxxxx/T/#u -- Ping-Ke
