On Mon, Oct 06, 2008 at 11:39:49PM +0200, Tomas Winkler wrote:
> On Mon, Oct 6, 2008 at 11:25 PM, John W. Linville
> <linville@xxxxxxxxxxxxx> wrote:
> >> diff --git a/drivers/net/wireless/iwlwifi/iwl-5000.c b/drivers/net/wireless/iwlwifi/iwl-5000.c
> >> index c1300fb..56a3f0c 100644
> >> --- a/drivers/net/wireless/iwlwifi/iwl-5000.c
> >> +++ b/drivers/net/wireless/iwlwifi/iwl-5000.c
> >> @@ -811,10 +811,14 @@ static int iwl5000_hw_set_hw_params(struct iwl_priv *priv)
> >>
> >> switch (priv->hw_rev & CSR_HW_REV_TYPE_MSK) {
> >> case CSR_HW_REV_TYPE_5100:
> >> + priv->hw_params.tx_chains_num = 1;
> >> + priv->hw_params.rx_chains_num = 2;
> >> + priv->hw_params.valid_tx_ant = ANT_B;
> >> + priv->hw_params.valid_rx_ant = ANT_AB;
> >> + break;
> >> case CSR_HW_REV_TYPE_5150:
> >> priv->hw_params.tx_chains_num = 1;
> >> priv->hw_params.rx_chains_num = 2;
> >> - /* FIXME: move to ANT_A, ANT_B, ANT_C enum */
> >> priv->hw_params.valid_tx_ant = ANT_A;
> >> priv->hw_params.valid_rx_ant = ANT_AB;
> >> break;
> >
> > Do you realize that both clauses are the same (i.e. there is no
> > functional change)? How is this useful?
>
> The change is tx_ant
Quite right.
> > You need to change the comment...
>
> Right
Thanks.
John
--
John W. Linville Linux should be at the core
linville@xxxxxxxxxxxxx of your literate lifestyle.
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
