On Mon, 22 Nov 2021 at 15:23, Kalle Valo <kvalo@xxxxxxxxxxxxxx> wrote: > > Loic Poulain <loic.poulain@xxxxxxxxxx> writes: > > > Hi Kalle, > > > > On Mon, 22 Nov 2021 at 12:01, Kalle Valo <kvalo@xxxxxxxxxxxxxx> wrote: > >> > >> Loic Poulain <loic.poulain@xxxxxxxxxx> writes: > >> > >> > When system enter suspend, there is no more wireless traffic, and > >> > if there is no incoming data, most of the AP kick-out the client > >> > station after few minutes because of inactivity. > >> > > >> > The usual way to prevent this is to submit a Null function frame > >> > periodically as a keep-alive. This is supported by brcm controllers > >> > and can be configured via the mkeep_alive IOVAR. > >> > >> This is with brcmfmac in client mode, right? > > > > Right, it's in client mode. > > > >> Wouldn't it make more sense to disconnect entirely during suspend? > >> Nobody is processing the data packets anyway during suspend. > > > > Disconnect is performed automatically when wowlan is not enabled, > > otherwise we may want to wake-up on events (disconnect, > > 4-way-handshake) or data packets (magic, unicast, etc...). Some > > devices use suspend aggressively such as Android in which the network > > link is expected to be maintained. > > Sure, for wowlan it makes sense but you didn't mention that in the > commit log so I assumed that was disabled. Ah right, I'll do that in V2. Thanks, Loic