> -----Original Message----- > From: Larry Finger <larry.finger@xxxxxxxxx> On Behalf Of Larry Finger > Sent: Saturday, November 20, 2021 4:07 AM > To: Pkshih <pkshih@xxxxxxxxxxx>; kvalo@xxxxxxxxxxxxxx > Cc: linux-wireless@xxxxxxxxxxxxxxx; 李佳遠 <leo.li@xxxxxxxxxxx> > Subject: Re: [PATCH] rtw89: add AXIDMA and TX FIFO dump in mac_mem_dump > > On 11/18/21 23:59, Ping-Ke Shih wrote: > > From: Chia-Yuan Li <leo.li@xxxxxxxxxxx> > > > > The AXIDMA is tx/rx packet transmission between PCIE host > > and device, and TX FIFO is MAC TX data. > > We dump them to ensure these memory buffers correct. > > > > Signed-off-by: Chia-Yuan Li <leo.li@xxxxxxxxxxx> > > Signed-off-by: Ping-Ke Shih <pkshih@xxxxxxxxxxx> > > The code in this patch is fine, but I think you may want to change the commit > message. Te mo, "We dump them to ensure these memory buffers correct" means that > the change here will fix the memory buffers. I think you want to say "We dump > them to verify that these memory buffers are correct." This means that you are > providing a way to dump the buffers so that their correctness can be determined. > > Reviewed-by: Larry Finger <Larry.Finger@xxxxxxxxxxxx" I have fixed and sent v2. Thank you. -- Ping-Ke
