On Thu, Nov 18, 2021 at 10:36:32PM -0800, Martinez, Ricardo wrote: > On 11/1/2021 7:03 AM, Andy Shevchenko wrote: > > On Sun, Oct 31, 2021 at 08:56:23PM -0700, Ricardo Martinez wrote: ... > > > + ret = cldma_gpd_rx_from_queue(queue, budget, &over_budget); > > > + if (ret == -ENODATA) > > > + return 0; > > > + > > > + if (ret) > > > + return ret; > > Drop redundant blank line > > The style followed is to keep a blank line after 'if' blocks. > > Is that acceptable as long as it is consistent across the driver? The idea behind suggestion is that you check for value returned from the call. So, both if:s are tighten to that call and can be considered as a whole. It doesn't mean you should blindly remove blank lines everywhere. ... > > > +exit: > > Seems useless. > > This tag is used when the PM patch is introduced later in the same series. Can you give it better name? > > + return ret; -- With Best Regards, Andy Shevchenko
