Search Linux Wireless

Re: [PATCH] mwl8k: Use struct_group() for memcpy() region

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

To: Kees Cook <keescook@xxxxxxxxxxxx>, Lennert Buytenhek <buytenh@xxxxxxxxxxxxxx>
Subject: Re: [PATCH] mwl8k: Use struct_group() for memcpy() region
From: Johannes Berg <johannes@xxxxxxxxxxxxxxxx>
Date: Thu, 18 Nov 2021 20:45:22 +0100
Cc: Kalle Valo <kvalo@xxxxxxxxxxxxxx>, "David S. Miller" <davem@xxxxxxxxxxxxx>, Jakub Kicinski <kuba@xxxxxxxxxx>, wengjianfeng <wengjianfeng@xxxxxxxxxx>, Lv Yunlong <lyl2019@xxxxxxxxxxxxxxxx>, Arnd Bergmann <arnd@xxxxxxxx>, Christophe JAILLET <christophe.jaillet@xxxxxxxxxx>, Allen Pais <allen.lkml@xxxxxxxxx>, Zheyu Ma <zheyuma97@xxxxxxxxx>, linux-kernel@xxxxxxxxxxxxxxx, linux-wireless@xxxxxxxxxxxxxxx, netdev@xxxxxxxxxxxxxxx, linux-hardening@xxxxxxxxxxxxxxx
In-reply-to: <20211118183700.1282181-1-keescook@chromium.org>
References: <20211118183700.1282181-1-keescook@chromium.org>
User-agent: Evolution 3.42.1 (3.42.1-1.fc35)

On Thu, 2021-11-18 at 10:37 -0800, Kees Cook wrote:
> 
> -	__u8 key_material[MAX_ENCR_KEY_LENGTH];
> -	__u8 tkip_tx_mic_key[MIC_KEY_LENGTH];
> -	__u8 tkip_rx_mic_key[MIC_KEY_LENGTH];
> +	struct {
> +			__u8 key_material[MAX_ENCR_KEY_LENGTH];
> 

That got one tab too many?

johannes

Follow-Ups:
- Re: [PATCH] mwl8k: Use struct_group() for memcpy() region
  - From: Kees Cook

References:
- [PATCH] mwl8k: Use struct_group() for memcpy() region
  - From: Kees Cook

Prev by Date: [PATCH] intersil: Use struct_group() for memcpy() region
Next by Date: Re: [PATCH] intersil: Use struct_group() for memcpy() region
Previous by thread: [PATCH] mwl8k: Use struct_group() for memcpy() region
Next by thread: Re: [PATCH] mwl8k: Use struct_group() for memcpy() region
Index(es):
- Date
- Thread

[Index of Archives] [Linux Host AP] [ATH6KL] [Linux Wireless Personal Area Network] [Linux Bluetooth] [Wireless Regulations] [Linux Netdev] [Kernel Newbies] [Linux Kernel] [IDE] [Git] [Netfilter] [Bugtraq] [Yosemite Hiking] [MIPS Linux] [ARM Linux] [Linux RAID]