Wen Gong <quic_wgong@xxxxxxxxxxx> wrote: > When station connect to AP, the wmi command sequence is: > > peer_create->vdev_start->vdev_up > > and sequence of station disconnect fo AP is: > > peer_delete->vdev_down->vdev_stop > > The sequence of disconnect is not opposite of connect, it caused firmware > crash when it handle wmi vdev stop cmd when the AP is support TWT of > 802.11 ax, because firmware need access the bss peer for vdev stop cmd. > > [ 390.438564] ath11k_pci 0000:05:00.0: wmi cmd send 0x6001 ret 0 > [ 390.438567] ath11k_pci 0000:05:00.0: WMI peer create vdev_id 0 peer_addr c4:04:15:3b:e0:39 > [ 390.472724] ath11k_pci 0000:05:00.0: mac vdev 0 start center_freq 2437 phymode 11ax-he20-2g > [ 390.472731] ath11k_pci 0000:05:00.0: wmi cmd send 0x5003 ret 0 > [ 390.560849] ath11k_pci 0000:05:00.0: wmi cmd send 0x5005 ret 0 > [ 390.560850] ath11k_pci 0000:05:00.0: WMI mgmt vdev up id 0x0 assoc id 1 bssid c4:04:15:3b:e0:39 > > [ 399.432896] ath11k_pci 0000:05:00.0: WMI peer delete vdev_id 0 peer_addr c4:04:15:3b:e0:39 > [ 399.432902] ath11k_pci 0000:05:00.0: wmi cmd send 0x6002 ret 0 > [ 399.441380] ath11k_pci 0000:05:00.0: wmi cmd send 0x5007 ret 0 > [ 399.441381] ath11k_pci 0000:05:00.0: WMI vdev down id 0x0 > [ 399.454681] ath11k_pci 0000:05:00.0: wmi cmd send 0x5006 ret 0 > [ 399.454682] ath11k_pci 0000:05:00.0: WMI vdev stop id 0x0 > > The opposite sequence of disconnect should be: > > vdev_down->vdev_stop->peer_delete > > This patch change the sequence of disconnect for station as above > opposite sequence for QCA6390, firmware not crash again with this patch. > > Tested-on: QCA6390 hw2.0 PCI WLAN.HST.1.0.1-01740-QCAHSTSWPLZ_V2_TO_X86-1 > > Signed-off-by: Wen Gong <quic_wgong@xxxxxxxxxxx> > Signed-off-by: Kalle Valo <kvalo@xxxxxxxxxxxxxx> Patch applied to ath-next branch of ath.git, thanks. b4a0f54156ac ath11k: move peer delete after vdev stop of station for QCA6390 and WCN6855 -- https://patchwork.kernel.org/project/linux-wireless/patch/20211027093825.12167-1-quic_wgong@xxxxxxxxxxx/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
