Hello, > I prefer marking it. > struct iwl_priv *priv = priv_r __maybe_unused; First of all , in order to compile, this should be: struct iwl_priv *priv __maybe_unused = priv_r; instead of: struct iwl_priv *priv = priv_r __maybe_unused; Second, this is also a possible solution; looking at the function immediately above in the same file (rs_clear() in iwl-agn-rs.c) we can see the same usage of #ifdef CONFIG_IWLWIFI_DEBUG and not __maybe_unused. I wonder: does the "__maybe_unused" solution better than the #ifdef solution in any aspect? Regards, Rami Rosen On Mon, Oct 6, 2008 at 4:41 PM, Tomas Winkler <tomasw@xxxxxxxxx> wrote: > On Mon, Oct 6, 2008 at 3:58 PM, Rami Rosen <ramirose@xxxxxxxxx> wrote: >> When CONFIG_IWLWIFI_DEBUG is not set and CONFIG_IWLWIFI is set, >> we get this compilation warning: >> /wireless-next-2.6/drivers/net/wireless/iwlwifi/iwl-agn-rs.c: In >> function 'rs_free_sta': >> /wireless-next-2.6/drivers/net/wireless/iwlwifi/iwl-agn-rs.c:2425: >> warning: unused variable 'priv' >> >> This patch (against wireless-next-2.6 tree) fixes it. >> > > I prefer marking it. > struct iwl_priv *priv = priv_r __maybe_unused; > -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
