Just tested it and it passes the rt2x00lib_load_firmware but still errors on rt2800usb_set_device_state:
[ 348.363942] ieee80211 phy1: rt2x00lib_request_firmware: Info - Loading firmware file 'rt2870.bin'
[ 348.364519] ieee80211 phy1: rt2x00lib_request_firmware: Info - Firmware detected - version: 0.36
[ 348.650321] ieee80211 phy1: rt2x00usb_vendor_request: Error - Vendor Request 0x06 failed for offset 0x0404 with error -71
[ 349.695576] ieee80211 phy1: rt2800_wait_csr_ready: Error - Unstable hardware
[ 349.695606] ieee80211 phy1: rt2800usb_set_device_state: Error - Device failed to enter state 4 (-5)
which was the last error i got in my previous dump_stack too (which you linked):
2020-07-15T19:16:10.956602+0000 kernel: Call Trace:
2020-07-15T19:16:10.956620+0000 kernel: dump_stack+0x64/0x88
2020-07-15T19:16:10.956635+0000 kernel: rt2x00usb_vendor_request.cold+0x2b/0x69 [rt2x00usb]
2020-07-15T19:16:10.956649+0000 kernel: rt2x00usb_vendor_req_buff_lock+0xa6/0x230 [rt2x00usb]
2020-07-15T19:16:10.956663+0000 kernel: rt2x00usb_register_write_lock+0x37/0x60 [rt2800usb]
2020-07-15T19:16:10.956677+0000 kernel: rt2800_mcu_request+0x100/0x110 [rt2800lib]
2020-07-15T19:16:10.956696+0000 kernel: rt2800_enable_radio+0xb6/0x2d36 [rt2800lib]
2020-07-15T19:16:10.956712+0000 kernel: rt2800usb_set_device_state+0xbd/0x18b [rt2800usb]
2020-07-15T19:16:10.956735+0000 kernel: rt2x00lib_enable_radio+0x3e/0xa0 [rt2x00lib]
2020-07-15T19:16:10.956754+0000 kernel: rt2x00lib_start+0x7c/0xc0 [rt2x00lib]
2020-07-15T19:16:10.956778+0000 kernel: drv_start+0x3e/0x130 [mac80211]
Anton "exuvo" Olsson
exuvo@xxxxxxxx
On 2021-11-09 13:07, Stanislaw Gruszka wrote:
On Tue, Nov 09, 2021 at 08:32:07AM +0100, Stanislaw Gruszka wrote:
On Mon, Nov 08, 2021 at 07:00:20PM +0100, Thorsten Leemhuis wrote:
Sending this again, but this time also to Stanislaw's email address
currently found in MAINTAINERS.
Stanislaw, can you help with this regression?
Yes.
I'll check on mail archives what is the status and what can be done.
Ok, so what I can see here
https://lore.kernel.org/linux-wireless/20211109073127.GA109212@xxxxx/T/#m6a677995c1afaf6b9b1ff19de9566f304089d3ac
is that this problem happen only on firmware load,
so I think we can use below patch as fix.
Anton, please test it.
Thanks
Stanislaw
diff --git a/drivers/net/wireless/ralink/rt2x00/rt2x00usb.c b/drivers/net/wireless/ralink/rt2x00/rt2x00usb.c
index e4473a551241..57c947dad036 100644
--- a/drivers/net/wireless/ralink/rt2x00/rt2x00usb.c
+++ b/drivers/net/wireless/ralink/rt2x00/rt2x00usb.c
@@ -30,7 +30,8 @@ static bool rt2x00usb_check_usb_error(struct rt2x00_dev *rt2x00dev, int status)
else
rt2x00dev->num_proto_errs = 0;
- if (rt2x00dev->num_proto_errs > 3)
+ if (rt2x00dev->num_proto_errs > 3 &&
+ !test_bit(DEVICE_STATE_STARTED, &rt2x00dev->flags))
return true;
return false;
