On Mon, 2008-10-06 at 01:45 -0500, Robin Holt wrote: > On Sun, Oct 05, 2008 at 10:38:41AM +0200, Johannes Berg wrote: > > On Sat, 2008-10-04 at 21:31 -0500, Robin Holt wrote: > > > > > > Will try it. To reproduce, suspend, wait 5 or so minutes, resume, > > > repeat until your keyboard leds stop flashing (usually within 3 or so > > > cycles). I think this will kick us out of the loop. > > It worked fine. It makes sense why it works, but it feels like we are > working around another bug instead of fixing it. I certainly do not > have any idea what I am talking about here, so feel free to tell me to > shut up ;) "shut up" ;) There are reasons that debugfs addition can fail, while most of them are error conditions that seems no reason to lock up here. > CONFIG_MAC80211_RC_PID=y > CONFIG_MAC80211_RC_DEFAULT_PID=y > CONFIG_MAC80211_RC_DEFAULT="pid" > # CONFIG_MAC80211_MESH is not set > CONFIG_MAC80211_LEDS=y > CONFIG_MAC80211_DEBUGFS=y Your config doesn't seem anything out of the ordinary, would you add a few printks to ieee80211_sta_debugfs_add to see where it drops out? Either way though, we should handle errors from debugfs_create_dir() which this patch boils down to. johannes
Attachment:
signature.asc
Description: This is a digitally signed message part
