Kevin Lo <kevlo@xxxxxxxxx> wrote: > It seems to me when pub_cfg->grp0 + pub_cfg->grp1 != pub_cfg->pub_max is true, > it should return -EFAULT rather than 0. Otherwise, the function doesn't need > to exist. > > Signed-off-by: Kevin Lo <kevlo@xxxxxxxxx> > Acked-by: Ping-Ke Shih <pkshih@xxxxxxxxxxx> > > diff --git a/drivers/net/wireless/realtek/rtw89/mac.c b/drivers/net/wireless/realtek/rtw89/mac.c > index 69384c43c046..afcd07ab1de7 100644 > --- a/drivers/net/wireless/realtek/rtw89/mac.c > +++ b/drivers/net/wireless/realtek/rtw89/mac.c > @@ -560,7 +560,7 @@ static int hfc_pub_cfg_chk(struct rtw89_dev *rtwdev) > const struct rtw89_hfc_pub_cfg *pub_cfg = ¶m->pub_cfg; > > if (pub_cfg->grp0 + pub_cfg->grp1 != pub_cfg->pub_max) > - return 0; > + return -EFAULT; > > return 0; > } Patch applied to wireless-drivers-next.git, thanks. c6477cb23704 rtw89: fix return value in hfc_pub_cfg_chk -- https://patchwork.kernel.org/project/linux-wireless/patch/YXEJey8lKksAZif4@xxxxxxxxxxxx/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
