On Thu, Oct 21, 2021 at 01:34:25AM +0000, Pkshih wrote: > > > -----Original Message----- > > From: kvalo=codeaurora.org@xxxxxxxxxxxxxxxxx <kvalo=codeaurora.org@xxxxxxxxxxxxxxxxx> On Behalf Of Kalle > > Valo > > Sent: Wednesday, October 20, 2021 6:04 PM > > To: Pkshih <pkshih@xxxxxxxxxxx> > > Cc: cgel.zte@xxxxxxxxx; davem@xxxxxxxxxxxxx; kuba@xxxxxxxxxx; lv.ruyi@xxxxxxxxxx; > > linux-wireless@xxxxxxxxxxxxxxx; netdev@xxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx; Zeal Robot > > <zealci@xxxxxxxxxx> > > Subject: Re: [PATCH] rtw89: fix error function parameter > > > > Pkshih <pkshih@xxxxxxxxxxx> writes: > > > > >> -----Original Message----- > > >> From: kvalo=codeaurora.org@xxxxxxxxxxxxxxxxx > > >> <kvalo=codeaurora.org@xxxxxxxxxxxxxxxxx> On Behalf Of Kalle > > >> Valo > > >> Sent: Wednesday, October 20, 2021 4:50 PM > > >> To: cgel.zte@xxxxxxxxx > > >> Cc: davem@xxxxxxxxxxxxx; kuba@xxxxxxxxxx; Pkshih > > >> <pkshih@xxxxxxxxxxx>; lv.ruyi@xxxxxxxxxx; > > >> linux-wireless@xxxxxxxxxxxxxxx; netdev@xxxxxxxxxxxxxxx; > > >> linux-kernel@xxxxxxxxxxxxxxx; Zeal Robot > > >> <zealci@xxxxxxxxxx> > > >> Subject: Re: [PATCH] rtw89: fix error function parameter > > >> > > >> cgel.zte@xxxxxxxxx wrote: > > >> > > >> > From: Lv Ruyi <lv.ruyi@xxxxxxxxxx> > > >> > > > >> > This patch fixes the following Coccinelle warning: > > >> > drivers/net/wireless/realtek/rtw89/rtw8852a.c:753: > > >> > WARNING possible condition with no effect (if == else) > > >> > > > >> > Reported-by: Zeal Robot <zealci@xxxxxxxxxx> > > >> > Signed-off-by: Lv Ruyi <lv.ruyi@xxxxxxxxxx> > > >> > Acked-by: Ping-Ke Shih <pkshih@xxxxxxxxxxx> > > >> > > >> Failed to apply, please rebase on top of wireless-drivers-next. > > >> > > >> error: patch failed: drivers/net/wireless/realtek/rtw89/rtw8852a.c:753 > > >> error: drivers/net/wireless/realtek/rtw89/rtw8852a.c: patch does not apply > > >> error: Did you hand edit your patch? > > >> It does not apply to blobs recorded in its index. > > >> hint: Use 'git am --show-current-patch' to see the failed patch > > >> Applying: rtw89: fix error function parameter > > >> Using index info to reconstruct a base tree... > > >> Patch failed at 0001 rtw89: fix error function parameter > > >> > > >> Patch set to Changes Requested. > > >> > > > > > > I think this is because the patch is translated into spaces instead of tabs, > > > in this and following statements. > > > " if (is_2g)" > > > > Ah, I did wonder why it failed as I didn't see any similar patches. We > > have an item about this in the wiki: > > > > https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches#format_issues > > > > I don't know why neither. > > I check the mail header of this patch, the mailer is > "X-Mailer: git-send-email 2.25.1". It should work properly. > > Lv Ruyi, could you help to check what happens? > > -- > Ping-Ke Thanks for Ping-Ke's suggestion,you are right.The previous patch is translated into spaces instead of tabs,and I will submitt a new correct one.
