On Friday 03 October 2008 23:33:04 Harvey Harrison wrote: > OK, but you should still look at patch 1 for the unaligned access > helpers. Yeah it's broken (it removes bounds checks at the end) and unaligned is not needed. > The rest I'll kick to the bitbucket...although I think you should look > at the portion of patch 5 that touches the function b43_radio_init2060 > as it points out the _one_ place where a register is masking the value > of some other register...which is absolutely impossible to see unless > you do a series of patches like this. > > It may be that it is intentional, and it has been this way as far back > in the git history as I can find, but at least now it can be seen. > > - b43_radio_write16(dev, 0x0005, > - (b43_radio_read16(dev, 0x0081) & ~0x0008) | 0x0008); That's a bug in the dead code. We have more such bugs in the A-PHY code, but nobody cares. If you want to fix it, please read the specs and find out what should be here instead. Then send a patch that fixes this single line of code. -- Greetings Michael. -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
