greearb@xxxxxxxxxxxxxxx writes:
> From: Ben Greear <greearb@xxxxxxxxxxxxxxx>
>
> Print information about whether the message is the first timeout,
> and also print info if we manage to recover after a timeout.
>
> Signed-off-by: Ben Greear <greearb@xxxxxxxxxxxxxxx>
> ---
>
> NOTE: Not sure this is really something folks would want upstream, but
> maybe it helps someone else trying to debug this driver.
If the patch is not ready for upstream it's a good idea to mark it as
RFC, that way the maintainers can skip it automatically.
> + if (mdev->first_failed_mcu_cmd) {
> + dev_err(mdev->dev, "MCU: First success after failure: Message %08x (cid %lx ext_cid: %lx seq %d)\n",
> + cmd, FIELD_GET(__MCU_CMD_FIELD_ID, cmd),
> + FIELD_GET(__MCU_CMD_FIELD_EXT_ID, cmd), seq);
> + mdev->first_failed_mcu_cmd = 0;
> + }
> + else {
> + // verbose debugging
> + //dev_err(mdev->dev, "MCU: OK response to message %08x (cid %lx ext_cid: %lx seq %d)\n",
> + // cmd, FIELD_GET(__MCU_CMD_FIELD_ID, cmd),
> + // FIELD_GET(__MCU_CMD_FIELD_EXT_ID, cmd), seq);
> + }
No C++ comments and no commented out code, please.
--
https://patchwork.kernel.org/project/linux-wireless/list/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
